Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SP2] 리크루팅 알림신청 API를 inhouse API로 교체 #207

Merged
merged 1 commit into from
Oct 13, 2023
Merged

[SP2] 리크루팅 알림신청 API를 inhouse API로 교체 #207

merged 1 commit into from
Oct 13, 2023

Conversation

SeojinSeojin
Copy link
Member

@SeojinSeojin SeojinSeojin commented Oct 8, 2023 •
edited
Loading

Summary

  • AS-IS : google sheet API로 리크루팅 알림신청 요청을 보내고, 구글 시트에 이메일을 저장합니다.
  • TO-BE : 공홈팀 백엔드 API로 리크루팅 알림신청 요청을 보내고, 공홈팀 데이터베이스에 이메일을 저장합니다.

TO-BE로 가면 예상치 못한 서버 터짐 이슈가 줄어들기 때문에 그렇게 변경합니다!!

Comment

  • 서버 status 코드 (200, 201 등) 은 따로 상수화하면 좋을 것 같아요~

  • 그리고 매직넘버 집어넣은 것도 합쳐서 관리하면 (CURRENT_GENERATION 등의 상수로!) 좋을 것 같습니다!!

위 두 가지 #208 요 이슈로 만들어 두었어요!!!

@SeojinSeojin SeojinSeojin changed the title fix: use inhouse api in recruit notification section [SP2] 리크루팅 알림신청 API를 inhouse API로 교체 Oct 10, 2023
f0rever0
f0rever0 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@f0rever0 f0rever0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 좋아요! 구글 시트에 의존하지 않아서 훨씬 나은 개선이네요~!
상수화작업도 추후에 진행해봅시다!!

solar3070
solar3070 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@solar3070 solar3070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 나중에 api 관련 코드를 따로 빼서 관심사 분리를 해도 좋을 것 같네요!

@SeojinSeojin SeojinSeojin force-pushed the fix/#206_recruit-api-to-inhouse branch from 2c45a92 to 08c15d2 Compare October 12, 2023 01:15
@SeojinSeojin SeojinSeojin merged commit 04c7441 into develop Oct 13, 2023
1 check passed
@SeojinSeojin SeojinSeojin deleted the fix/#206_recruit-api-to-inhouse branch October 13, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solar3070 solar3070 solar3070 approved these changes

@f0rever0 f0rever0 f0rever0 approved these changes

Assignees

@SeojinSeojin SeojinSeojin

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

리크루팅 알림신청 API를 inhouse로 교체
3 participants
@SeojinSeojin @f0rever0 @solar3070