Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SP2] 빌드 오류 수정 #211

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[SP2] 빌드 오류 수정 #211

merged 1 commit into from
Oct 11, 2023

Conversation

SeojinSeojin
Copy link
Member

Summary

@SeojinSeojin SeojinSeojin changed the title fix: apply pagelayout to about page [SP2] 빌드 오류 수정 Oct 10, 2023
f0rever0
f0rever0 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@f0rever0 f0rever0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네! 머지할때 이 pr을 가장 나중에 해야하는게 맞나요?!
다른 pr에는 기존 파일로 되어있어서 작업 내용이 덮어씌워질거라 생각이 돼서요!

@SeojinSeojin
Copy link
Member Author

요 pr부터 머지하고 다른 pr들은 rebase할 생각이었습니다 ..!!!

@f0rever0
Copy link
Contributor

아하 그런 방법을 생각중이셨군요! 좋습니다~!!

solar3070
solar3070 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@solar3070 solar3070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!! 👍👍

@SeojinSeojin
Copy link
Member Author

요것부터 머지할게요 ..! 확인 감사드립니다!!

@SeojinSeojin SeojinSeojin merged commit 768ff5b into develop Oct 11, 2023
1 check passed
@SeojinSeojin SeojinSeojin deleted the fix/#210_build-error branch October 11, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solar3070 solar3070 solar3070 approved these changes

@f0rever0 f0rever0 f0rever0 approved these changes

Assignees

@SeojinSeojin SeojinSeojin

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pagelayout 리펙토링이 적용되지 않아 빌드되지 않는 문제 해결
3 participants
@SeojinSeojin @f0rever0 @solar3070