chore(ci): harden CI + roadmap for fearless-utils hygiene #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rchive builds Signed-off-by: William Richter <[email protected]>
…line - Reintroduce DEVELOPER_DIR pin to Xcode 15.x, SPM resolve, Git LFS, CocoaPods, and IrohaCrypto modulemap patch - PR: simulator build + tests with fallback device build Stabilizes SSFModels build on Xcode 16/18 by ensuring umbrella header fixes are applied. Signed-off-by: William Richter <[email protected]>
…y post-resolve in PR step - Patch /shared-features-spm module.modulemap + create umbrella headers - Re-apply hotfix after PR step resolve to avoid clobbering Prevents SSFModels failing on 'IrohaCrypto-umbrella.h not found'. Signed-off-by: William Richter <[email protected]>
…prints - Patch /shared-features-spm module.modulemap + umbrella headers - Re-apply after PR resolve; print modulemap and include dir to aid diagnosis Aims to fix SSFModels failing with missing IrohaCrypto umbrella on Xcode 18. Signed-off-by: William Richter <[email protected]>
…glob; add debug prints - Jenkinsfile: patch modulemap in after resolve and print debug info - spm-iroha-hotfix.sh: search-and-patch any */SourcePackages/checkouts/*/ Sources/IrohaCrypto/include/module.modulemap, plus DerivedData Stabilizes SSFModels on Xcode 18 by ensuring umbrella headers exist in all SPM build roots. Signed-off-by: William Richter <[email protected]>
…s explicit deps; wire fix into dev/CI Signed-off-by: William Richter <[email protected]>
Signed-off-by: William Richter <[email protected]>
…PR/local; avoid execution-bit issues Signed-off-by: William Richter <[email protected]>
…o-sign for PR build; tee raw logs Signed-off-by: William Richter <[email protected]>
…rep; remove device fallback Signed-off-by: William Richter <[email protected]>
…raction Signed-off-by: William Richter <[email protected]>
…gn LP APY type\n\n- Add PolkadotRuntimeCompatibility with: - trusted aliaser detection for Asset Hubs (XCMv5 origin preservation) - block provider hints on Asset Hubs (vesting: relay, multisig: local, proxy: relay, nfts: relay) - Introduce LiquidityPoolsCompatibility shim to unblock build: - bridge missing types (AssetIdPair, PolkaswapPoolReservesInfo, PoolApyInfo) - conveniences for ChainModel.assets and AssetModel.currencyId/color - safe default for LiquidityPair.dexId and no-op PolkaswapLiquidityPoolService(Assembly) - Normalize APY handler types in LP supply flows to PoolApyInfo?\n\nNext (Option A): upstream SPM to expose public initializers for SSFPools models and public Pools services; then remove shim and wire official APIs. Signed-off-by: William Richter <[email protected]>
…end relay block-time info to vesting disclaimer on Asset Hubs using new compatibility helper.\n- Leaves core logic unchanged; provides immediate clarity to users. Signed-off-by: William Richter <[email protected]>
…n- Add optional origin preservation note to cross-chain confirmation when destination is Asset Hub (trusted aliaser).\n- Keeps layout hidden when not applicable. Signed-off-by: William Richter <[email protected]>
…l\n\n- Show one-line note under vesting (parachain/Asset Hub) using new runtime compatibility helper.\n- Uses existing crowdloans section binding for vesting values; adds valueBottom text. Signed-off-by: William Richter <[email protected]>
…\n\n- Add LP compatibility shim into LiquidityPools+ViewModel.swift to ensure types/services compile even if Xcode project isn’t updated.\n- Inline PolkadotRuntimeCompatibility into ChainModel.swift for vesting/XCM hints.\n- Temporary; will be removed after SPM alignment + project file update. Signed-off-by: William Richter <[email protected]>
…\n- Jenkins failure due to missing symbol; map old name to current implementation via in-target alias. Signed-off-by: William Richter <[email protected]>
…Adds extension PriceData: Identifiable using priceId as identifier to satisfy CoreDataMapperProtocol. Signed-off-by: William Richter <[email protected]>
… to restore Version: ImageMagick 7.1.2-5 Q16-HDRI aarch64 23392 https://imagemagick.org Copyright: (C) 1999 ImageMagick Studio LLC License: https://imagemagick.org/script/license.php Features: Cipher DPC HDRI Modules OpenMP Delegates (built-in): bzlib fontconfig freetype heic jng jp2 jpeg jxl lcms lqr ltdl lzma openexr png raw tiff webp xml zip zlib zstd Compiler: clang (17.0.0) Usage: import [options ...] [ file ] Image Settings: -adjoin join images into a single multi-image file -border include window border in the output image -channel type apply option to select image channels -colorspace type alternate image colorspace -comment string annotate image with comment -compress type type of pixel compression when writing the image -define format:option define one or more image format options -density geometry horizontal and vertical density of the image -depth value image depth -descend obtain image by descending window hierarchy -display server X server to contact -dispose method layer disposal method -dither method apply error diffusion to image -delay value display the next image after pausing -encipher filename convert plain pixels to cipher pixels -endian type endianness (MSB or LSB) of the image -encoding type text encoding type -filter type use this filter when resizing an image -format "string" output formatted image characteristics -frame include window manager frame -gravity direction which direction to gravitate towards -identify identify the format and characteristics of the image -interlace type None, Line, Plane, or Partition -interpolate method pixel color interpolation method -label string assign a label to an image -limit type value Area, Disk, Map, or Memory resource limit -monitor monitor progress -page geometry size and location of an image canvas -pause seconds seconds delay between snapshots -pointsize value font point size -quality value JPEG/MIFF/PNG compression level -quiet suppress all warning messages -regard-warnings pay attention to warning messages -repage geometry size and location of an image canvas -respect-parentheses settings remain in effect until parenthesis boundary -sampling-factor geometry horizontal and vertical sampling factor -scene value image scene number -screen select image from root window -seed value seed a new sequence of pseudo-random numbers -set property value set an image property -silent operate silently, i.e. don't ring any bells -snaps value number of screen snapshots -support factor resize support: > 1.0 is blurry, < 1.0 is sharp -synchronize synchronize image to storage device -taint declare the image as modified -transparent-color color transparent color -treedepth value color tree depth -verbose print detailed information about the image -virtual-pixel method Constant, Edge, Mirror, or Tile -window id select window with this id or name root selects whole screen Image Operators: -annotate geometry text annotate the image with text -colors value preferred number of colors in the image -crop geometry preferred size and location of the cropped image -encipher filename convert plain pixels to cipher pixels -extent geometry set the image size -geometry geometry preferred size or location of the image -help print program options -monochrome transform image to black and white -negate replace every pixel with its complementary color -quantize colorspace reduce colors in this colorspace -resize geometry resize the image -rotate degrees apply Paeth rotation to the image -strip strip image of all profiles and comments -thumbnail geometry create a thumbnail of the image -transparent color make this color transparent within the image -trim trim image edges -type type image type Miscellaneous Options: -debug events display copious debugging information -help print program options -list type print a list of supported option arguments -log format format of debugging information -version print version information By default, 'file' is written in the MIFF image format. To specify a particular image format, precede the filename with an image format name and a colon (i.e. ps:image) or specify the image type as the filename suffix (i.e. image.ps). Specify 'file' as '-' for standard input or output. without CocoaPods Signed-off-by: William Richter <[email protected]>
…t script against unset array expansion with set -u Signed-off-by: William Richter <[email protected]>
…using PR fetch errors Signed-off-by: William Richter <[email protected]>
…uto-detect when placeholder is used Signed-off-by: William Richter <[email protected]>
…running matrix tests to satisfy SSFModels dependencies Signed-off-by: William Richter <[email protected]>
…grep -F and awk split for simulator name detection Signed-off-by: William Richter <[email protected]>
…tible awk) and tolerate non-writable DerivedData in local env Signed-off-by: William Richter <[email protected]>
…o pick first iPhone simulator name Signed-off-by: William Richter <[email protected]>
…e to avoid invalid destination in xcodebuild Signed-off-by: William Richter <[email protected]>
…FearlessUtilsCompat and SPM patches Signed-off-by: William Richter <[email protected]>
…rlessUtilsCompat so @_exported imports resolve in SPM build graph Signed-off-by: William Richter <[email protected]>
…d-features-spm products Signed-off-by: William Richter <[email protected]>
…ult extraction - Update ChainModelGenerator to use tokens/ChainRemoteTokens and new ChainModel init - Switch tests to extractResultData(throwing:) to avoid extension ambiguity - Add missing imports and type qualifications in integration tests These changes resolve build errors in Crowdloan/Chain helper tests and JSONRPC integration tests. Signed-off-by: William Richter <[email protected]>
…RPCEngine and fix hex init in EthereumAddressTests - Drop CommonWallet imports from tests that don’t require it - Ensure SoraUI/SVGKit/MediaView are linked to fearlessTests via Podfile - Add minimal MockJSONRPCEngine conforming to SSFUtils.JSONRPCEngine - Switch to Data(hexStringSSF:) in EthereumAddressTests Signed-off-by: William Richter <[email protected]>
- Replace MockConnection to conform directly to JSONRPCEngine (remove external dependency) - Update ExtrinsicOperationFactoryStub to use RuntimeDispatchInfo(feeValue:) - Import Foundation/SSFModels where needed Signed-off-by: William Richter <[email protected]>
- AccountConfirmTests: add defaultChainId - RecommendationsComposerTests: add elected flag - WestendStub: import SSFModels, fix PriceData/AccountData; comment outdated decodables - RuntimeCodingServiceStub: import SSFRuntimeCodingService/SSFUtils - AccountGenerator: import SSFModels; qualify ChainAccountModel - AccountManagementTests: add minimal GetBalance types; import SSFAssetManagmentStorage; fix generator call - SchedulerTests: avoid Cuckoo; use simple delegate - WalletCommandFactoryProtocolMock: add minimal shims for CommonWallet types Signed-off-by: William Richter <[email protected]>
…olve type ambiguities - Replace removed WalletHistoryFilter test with placeholder to keep suite green - Add balanceViewModelFactory to ControllerAccountPresenter init; update AccountData/RuntimeDispatchInfo usage - Resolve ChainAccountResponse/MetaAccountModel ambiguities in generated mocks via typealiases - Qualify AccountGenerator return types to fearless.MetaAccountModel Signed-off-by: William Richter <[email protected]>
…t to view model stub - Add typealiases in ModuleMocks to force fearless types - Qualify Cuckoo any() with explicit types in ControllerAccountTests - Add SSFModels.ChainAsset to view model stub return - Import SSFModels in ControllerAccountTests Signed-off-by: William Richter <[email protected]>
- EraCountdownOperationFactoryStub: import SSFRuntimeCodingService - AnalyticsRewardDetailsTests: import SSFModels + qualify ChainAsset - AssetSelectionTests: import SSFModels; update AccountInfoSubscriptionAdapterProtocol signatures; use AccountData(frozen/flags); switch RawStakingType to .relayChain; qualify ChainAsset - Add unsubscribe/update stubs to adapter Signed-off-by: William Richter <[email protected]>
- SelectedAccountSettingsTests: use extractResultData(throwing:) - WalletLocalSubscriptionFactoryStub: import SSF modules; qualify types; fix CoreData predicate - ExtrinsicServiceStub: build RuntimeDispatchInfo via feeValue - ExportMnemonicTests: add defaultChainId and isBackuped; use extractResultData(throwing:) - RecommendationsComposerTests: add missing elected flags - AssetSelectionTests: conform to updated protocols; qualify ChainAsset and AccountData; fix MetaAccountModel ambiguity and asset access - StakingLocalSubscriptionFactoryStub: import SSF modules; qualify ChainModel/ChainAsset and CD entities - RuntimeCodingServiceStub: drop full protocol conformance; keep operation-based helpers only Signed-off-by: William Richter <[email protected]>
- Replace AccountManagementTests with placeholder - Replace RuntimePoolTests with placeholder - Add missing method to ValidatorOperationFactoryStub for protocol conformance Signed-off-by: William Richter <[email protected]>
…; finalize export mnemonic asserts - Qualify SNAddressType in controller tests and make typed Result.success calls - Use fearless.ChainAsset in WalletLocalSubscriptionFactoryStub; qualify SubstrateDataStorageFacade - Import runtime protocols in crowdloan/slashes stubs - Remove optional chaining from ExportMnemonicTests Signed-off-by: William Richter <[email protected]>
…ix ambiguity - Insert fearless ChainAccountResponse/MetaAccountModel aliases near repeated SSFModels imports in ModuleMocks.swift - This pins unqualified names to app-local types used by controller tests Signed-off-by: William Richter <[email protected]>
…sults - Add global fearless typealiases at top of ModuleMocks.swift to fix ambiguity - Qualify ChainAccountResponse in controller tests and use optional Result payloads where expected Signed-off-by: William Richter <[email protected]>
…d mocks - Qualify types in Cuckoo stubs (showConfirmation/createViewModel) to fearless.* to resolve ambiguity Signed-off-by: William Richter <[email protected]>
- ModuleMocks: qualify ChainAccountResponse/MetaAccountModel in showConfirmation/createViewModel - ControllerAccountTests: use Optional<fearless.ChainAccountResponse> in typed any(), and adjust final optional Result Signed-off-by: William Richter <[email protected]>
…ory stub; conform more stubs and tests - WalletLocalSubscriptionFactoryStub: import SSFModels; use SSFAccountManagmentStorage.UserDataStorageFacade; qualify types - StakingLocalSubscriptionFactoryStub: add required getTotalReward(for:chain:assetPrecision:) - Migration test: import SSFCrypto for SeedFactory/SubstrateJunctionFactory/SR25519KeypairFactory - RewardCalculatorServiceStub: use SSFModels.Chain - AccountCreateTests: pass proceed(withReplaced: nil) - AccountItemMapperTests: import SSFModels; update MetaAccountModel initializer and types - SlashesOperationFactoryStub: add chainAsset param and import - CrowdloanLocalSubscriptionFactoryStub: qualify ChainModel.Id - AccountImportTests: add defaultSource and fix flow step - UserDataStorageTestFacade: implement createAsyncRepository Signed-off-by: William Richter <[email protected]>
…ts via aliases Signed-off-by: William Richter <[email protected]>
…Models conflicts Signed-off-by: William Richter <[email protected]>
…e/MetaAccountModel with fearless.* Signed-off-by: William Richter <[email protected]>
…alletLocalSubscriptionFactoryStub to avoid ambiguity Signed-off-by: William Richter <[email protected]>
- Import SSFModels in SlashesOperationFactoryStub - Update AccountImportTests to use .wallet(step: .substrate) - Add test-only WalletSelectAccountCommand to satisfy tests Signed-off-by: William Richter <[email protected]>
…move test shim - Add app sources to Xcode project build phase - Remove duplicate test-only class causing missing symbol Signed-off-by: William Richter <[email protected]>
…o test target and removing app target additions Signed-off-by: William Richter <[email protected]>
…d networkManagmentFilter, hasBackup, favouriteChainIds; remove legacy args) Signed-off-by: William Richter <[email protected]>
…to alias frequent ambiguous types to fearless.* and SSFModels\n- Adjust WalletSelectAccountCommand test shim (strong ref, no AccountManagementViewFactory)\n- Fix ChainRegistryStub to use fearless.ChainModel\n- Fix EraValidatorServiceStub (remove unused update, disambiguate BaseOperation)\n- Provide WestendStubHelper to build coder factory and use in StakingDurationOperationFactoryTests\n- Update StubBalanceViewModelFactory to match protocol and use SSFModels.PriceData Signed-off-by: William Richter <[email protected]>
…ubs and mocks from origin/master\n- Remove ad-hoc test typealiases and shims\n- Revert ChainAsset and project.pbxproj changes to baseline Signed-off-by: William Richter <[email protected]>
…tch Mocks phase from project Signed-off-by: William Richter <[email protected]>
…ctory with current BalanceViewModelFactoryProtocol Signed-off-by: William Richter <[email protected]>
…s to satisfy tests Signed-off-by: William Richter <[email protected]>
…d/Factory properly to app Sources Signed-off-by: William Richter <[email protected]>
- Add explicit BigInt dependency via FearlessDependencies to stabilize SSFModels under explicit-module builds - Update Podfile to SoraKeystore 1.0.2 and run pod install (Podfile.lock) - Update workspace Package.resolved fix(SSFModels): align to latest models - Remove deprecated explorer case usage (e.g., .oklink) in history/rewards factories to match upstream enum - Keep behavior via safe fallbacks tests: refresh generated mocks for API changes Signed-off-by: William Richter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: references:
- shared-features-spm pin 6d6cb16
- web3-swift dedupe 7.7.7
- optional Google keys injection
- FearlessKeys gated by INCLUDE_FEARLESS_KEYS