Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android notification crash #254

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Fix android notification crash #254

merged 4 commits into from
Sep 8, 2023

Conversation

rottabonus
Copy link
Member

@rottabonus rottabonus commented Sep 7, 2023 •
edited
Loading

What has changed?

  • Fixed bug that application crashed when receiving notification with Android 13+ (when application was on background)
  • Additionally I upgraded the firebase-libs to the latest, while I was testing the notifications ( I did not dare to update them before out of risk of breaking anything, but now that I tested them anyways, I did it )

Why was the change made?

  • Bug fix

How was tested?

  • Pixel 5, Android 13 (release mode)
  • Honor 8, Android 7 (release mode)
  • iPhone 13 mini, iOS 16.6 (release mode)
  • We can run the application still in debug mode on emulators/simulators

Related Trello issue

Link to the Trello ticket

Checklist

  • I have updated relevant documentation in READMES

@rottabonus rottabonus changed the title WIP: Fix android notification crash Fix android notification crash Sep 8, 2023
@rottabonus rottabonus marked this pull request as ready for review September 8, 2023 05:09
@rottabonus rottabonus merged commit a1b7036 into master Sep 8, 2023
2 checks passed
@rottabonus rottabonus deleted the felix/android-notification-crash branch September 8, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idolgov idolgov idolgov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rottabonus @idolgov