Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum version handling #277

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Minimum version handling #277

merged 6 commits into from
Oct 11, 2024

Conversation

rottabonus
Copy link
Member

@rottabonus rottabonus commented Sep 29, 2024

What has changed?

Minimum version handling for mobile client

  • If not minimum version, then direct user to store
  • Store-url is a build configuration variable (different for ios and android app)

Testing has been done by Felix and Eppu with builds from AppCenter ✅

Why was the change made?

Currently we are forced to be backwards compatible. We need to implement this so we can be somewhat sure that users are using up to date applications as time passes.

Caveats?

NA

Related Trello issue

Checklist

  • I have updated relevant documentation in READMES

- Later on improve the logic, but now start with the boilerplate
- Also add accessToken to versions request (forgot we decided it is behind authentication, therefore we can only do the check after user has logged in)
@rottabonus rottabonus force-pushed the felix/minimum-version-handling branch from 52b20b7 to 341cff8 Compare October 6, 2024 07:59
- select if application version isBigEnough
@rottabonus rottabonus force-pushed the felix/minimum-version-handling branch 5 times, most recently from 5682ae9 to 4899985 Compare October 9, 2024 15:54
@rottabonus rottabonus changed the title WIP: Minimum version handling Minimum version handling Oct 9, 2024
@rottabonus rottabonus force-pushed the felix/minimum-version-handling branch from 4899985 to bf45022 Compare October 9, 2024 16:08
- Use storeurl as a build config
@rottabonus rottabonus force-pushed the felix/minimum-version-handling branch from bf45022 to fb29811 Compare October 9, 2024 16:09
@rottabonus rottabonus marked this pull request as ready for review October 9, 2024 16:12
@rottabonus rottabonus requested review from pheis and idolgov October 9, 2024 16:12
Copy link
Contributor

@pheis pheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Katotaaks puhelulla lapi? Liian monta rivia :D

pheis
pheis previously approved these changes Oct 10, 2024
@rottabonus rottabonus merged commit 3246312 into master Oct 11, 2024
2 checks passed
@rottabonus rottabonus deleted the felix/minimum-version-handling branch October 11, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants