-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum version handling #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Later on improve the logic, but now start with the boilerplate
- Also add accessToken to versions request (forgot we decided it is behind authentication, therefore we can only do the check after user has logged in)
52b20b7
to
341cff8
Compare
- select if application version isBigEnough
5682ae9
to
4899985
Compare
4899985
to
bf45022
Compare
- Use storeurl as a build config
bf45022
to
fb29811
Compare
pheis
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Katotaaks puhelulla lapi? Liian monta rivia :D
pheis
reviewed
Oct 10, 2024
pheis
reviewed
Oct 10, 2024
pheis
reviewed
Oct 10, 2024
pheis
previously approved these changes
Oct 10, 2024
idolgov
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
Minimum version handling for mobile client
Testing has been done by Felix and Eppu with builds from AppCenter ✅
Why was the change made?
Currently we are forced to be backwards compatible. We need to implement this so we can be somewhat sure that users are using up to date applications as time passes.
Caveats?
NA
Related Trello issue
Checklist