Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[global] Fix alerts for mixing implicit and explicit returns #3367

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

TurboTurtle
Copy link
Member

This commit resolves the alerts generated by GitHub code scanning for mixing implicit and explicit returns. In most cases this is simply changing empty or implicit returns to return None, while in a few other places the return logic is slightly reworked.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

This commit resolves the alerts generated by GitHub code scanning for
mixing implicit and explicit returns. In most cases this is simply
changing empty or implicit returns to `return None`, while in a few
other places the return logic is slightly reworked.

Signed-off-by: Jake Hunsaker <[email protected]>
@TurboTurtle
Copy link
Member Author

I have not manually tested these changes yet since I am doing this from the airport on a new employer's Mac (FSM, have mercy this is painful), so I'm leaning heavily on the CI here.

Once back in a sane development environment I'll take another sanity pass through here but I think these should overall be safe and trivial.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3367
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3367
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle TurboTurtle merged commit 98af3c7 into sosreport:main Oct 1, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants