Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -a to 'nft list rulest' command to add handle numbers to the output #3369

Merged
merged 1 commit into from
Oct 4, 2023
Merged

add -a to 'nft list rulest' command to add handle numbers to the output #3369

merged 1 commit into from
Oct 4, 2023

Conversation

korbdallas
Copy link

@korbdallas korbdallas commented Sep 29, 2023 •
edited by TurboTurtle
Loading

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3369
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[firewall_tables] Gather nft rule handle numbers
b9056a9 
Added -a to 'nft list rulest' command to add
handle numbers to the gathered output

Signed-off-by: Michael Colombo <[email protected]>
TurboTurtle
TurboTurtle approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack for the option, however is there any automation that might be sensitive to the change in filename? I.E. should we add a tag to this collection?

arif-ali
arif-ali approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TurboTurtle I don't see anything in our automation that would be affected

@TurboTurtle TurboTurtle merged commit e74122e into sosreport:main Oct 4, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmoravec pmoravec pmoravec approved these changes

@TurboTurtle TurboTurtle TurboTurtle approved these changes

@arif-ali arif-ali arif-ali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korbdallas @arif-ali @TurboTurtle @pmoravec