Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lxd][runtime] Add LXD Runtime #3373

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

arif-ali
Copy link
Member

@arif-ali arif-ali commented Oct 6, 2023


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3373
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly solid so far, just a couple minor comments. I'll get a PR up for the docker change shortly to cover that side of things.

sos/policies/runtimes/lxd.py Outdated Show resolved Hide resolved
sos/policies/runtimes/lxd.py Outdated Show resolved Hide resolved
sos/policies/runtimes/lxd.py Show resolved Hide resolved
@arif-ali
Copy link
Member Author

I'm not really happy with the way get_volumes() function is expecting the return, as lxc doesn't necessarily give ids, but names of the volumes. So, at the moment this is giving a list of names of volumes in the default storage pool or the pool from the default profile. This is going to be as good as it goes for the time being.

If this would have a refactor later, we could do with pool + name/id tuple, then that would work better for lxd, but that would mean that docker/podman ones would need to change too. Different concepts of volumes/storage, need to work on understanding how this is used in the wider sos aspect

@arif-ali arif-ali marked this pull request as ready for review October 11, 2023 11:07
@TurboTurtle TurboTurtle merged commit e41b535 into sosreport:main Oct 15, 2023
34 checks passed
@arif-ali arif-ali deleted the lxd_container_runtime branch October 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants