Collect mgr and more osd data for microceph #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that canonical/microceph#160 is fixed, gather the ceph daemon command outputs for OSD nodes. Signed-off-by: Nikhil Kshirsagar <[email protected]>
|
Some testing on microceph mgr and osd (colocated) nodes |
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
5 tasks
nkshirsagar
changed the title
pmoravec
reviewed
Oct 10, 2023
pmoravec
reviewed
Oct 10, 2023
pmoravec
approved these changes
Oct 10, 2023
arif-ali
requested changes
Oct 10, 2023
|
I just notice during testing, while the right files seem collected, this issue, Is this expected, could I get your thoughts please @UtkarshBhatthere @pponnuvel ? |
arif-ali
requested changes
Oct 10, 2023
Microceph does NOT use the ceph orchestrator backend. (Possible feature enhancement for future) So this looks okay to me. |
Maybe I should skip those collections then for micro ceph case... |
arif-ali
approved these changes
Oct 10, 2023
Yeah, orch backend implementation (although not researched too well) is a bit of a task I do not see it happening "soon". Another option would be to collect it only when orch backend is set (can use |
TurboTurtle
reviewed
Oct 10, 2023
I've changed the code to check the ceph orch status and if ENOENT is seen in its output, we do not collect any of the orch commands. This change will apply to the ceph plugins as well, since its in common code, for ceph as well as microceph. |
pmoravec
reviewed
Oct 11, 2023
pponnuvel
reviewed
Oct 11, 2023
Signed-off-by: Nikhil Kshirsagar <[email protected]>
|
Thank you everyone for the feedback, I think this one is in shape to merge now. |
pmoravec
reviewed
Oct 12, 2023
pmoravec
approved these changes
Oct 12, 2023
Thank you. I won't make any more changes to this PR now, so please merge when possible. |
arif-ali
approved these changes
Oct 13, 2023
TurboTurtle
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines