Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snap] Add more items to collect #3382

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

arif-ali
Copy link
Member

Resolves: SET-313


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3382
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3382
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

sos/report/plugins/snap.py Outdated Show resolved Hide resolved
sos/report/plugins/snap.py Outdated Show resolved Hide resolved
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arif-ali
Copy link
Member Author

just added another section, thought we would need a plugin for each of the gadget snaps, but that is only really defined in the Notes field, and no easy trigger. So added to be consistent with our teams debug collection script

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New section looks good to me, just a minor note that I overlooked earlier. If snap changes is indeed no longer wanted as saved output then this all looks fine to me at this point.

sos/report/plugins/snap.py Show resolved Hide resolved
Resolves: SET-313
Signed-off-by: Arif Ali <[email protected]>
@TurboTurtle TurboTurtle merged commit 8996db2 into sosreport:main Oct 15, 2023
34 checks passed
@arif-ali arif-ali deleted the sos-arif-snap-debug branch October 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants