-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging.version related changes: chatch the proper exception and switch the priority #3383
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
This was discussed in #3126, and the preference of using |
I actually want to get rid of setuptools from BaseOS in RHEL 10+. |
OK, we at Canonical will need to be aware of this change, so that the relevant changes can be made too for Ubuntu OSs too. We have |
Generally ACK, just unsure about the flake failure (https://github.com/sosreport/sos/pull/3383/checks?check_run_id=17680606514):
Technically the error is right, practically
|
I've added a commit to please the linter in the way I consider "proper". If you do not like that, I can remove the two commits and leave the function definition as it was, because that's now what I came here to do anyway. |
Getting SyntaxError from pkg_resources is unlikely. I hereby declare that you can do whatever you want with this commit: Signed-off-by: Miro Hrončok <[email protected]>
This seems a bit more straightforward and achieves the same result. This also defines the API of sos.utilities to avoid flake8 "imported but unused" I hereby declare that you can do whatever you want with this commit: Signed-off-by: Miro Hrončok <[email protected]>
pkg_resources bundle and call packaging.version internally anyway. In RHEL 10 and Ubuntu, we have packaging in BaseOS/main. I hereby declare that you can do whatever you want with this commit: Signed-off-by: Miro Hrončok <[email protected]>
Rebased, hopefully, the commits now adhere to the rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, though I should note that we were indeed seeing SyntaxError
previously.
For future contributions, please note that we prefer [tags]
in the commit title, as it makes groking through the git history much easier, but this change I'm not going to be a stickler about it.
A followup: #3398 |
Related: sosreport#3398 Related: sosreport#3383 Resolves: SET-326 Signed-off-by: Arif Ali <[email protected]>
Related: #3398 Related: #3383 Resolves: SET-326 Signed-off-by: Arif Ali <[email protected]>
I am sending this as a draft as I won't be able to finish the checklist right away. Please do let me know if this seems OK to you and if so, I can amend the magical phrase to commit messages and rewrap them at 72 characters.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines