Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openvswitch] Add driverctl verbose option #3386

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

kevintraynor
Copy link
Contributor

driverctl commands give info about which drivers are used for devices. They list PCI address and driver used e.g.

0000:01:00.0 vfio-pci

This can usually be correlated to the device type through lspci. However, lspci may not be available if only some plugins were captured as part of the report.

Even when lspci info is available, it is still convienent to have the device type co-located with the driver and override information.

Add verbose option to driverctl commands that support it to also list device type. e.g. (wrapped for line length)

0000:01:00.0 vfio-pci
(82599ES 10-Gigabit SFI/SFP+ Network Connection
(Ethernet 10G 4P X520/I350 rNDC))


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

driverctl commands give info about which drivers are used
for devices. They list PCI address and driver used e.g.

0000:01:00.0 vfio-pci

This can usually be correlated to the device type through lspci.
However, lspci may not be available if only some plugins were
captured as part of the report.

Even when lspci info is available, it is still convienent to have
the device type co-located with the driver and override information.

Add verbose option to driverctl commands that support it to also
list device type. e.g. (wrapped for line length)

0000:01:00.0 vfio-pci
 (82599ES 10-Gigabit SFI/SFP+ Network Connection
 (Ethernet 10G 4P X520/I350 rNDC))

Signed-off-by: Kevin Traynor <[email protected]>
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3386
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle TurboTurtle merged commit ab36ea6 into sosreport:main Oct 20, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants