Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utilities|collect] Capture ImportError exceptions #3387

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jcastill
Copy link
Member

Capture two ImportError exceptions when
calling import()


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3387
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle
Copy link
Member

This....doesn't do anything different?

Catching and simply re-raising the exception without any other action is the same as not catching it in the try block...we just end up handing the same exception to the caller.

Capture two ImportError exceptions when
calling __import__()

Signed-off-by: Jose Castillo <[email protected]>
@jcastill jcastill force-pushed the jcastillo-capture-importerrors branch from 0f188e8 to b8370cb Compare October 18, 2023 15:27
@jcastill
Copy link
Member Author

I've added some logging to have a clearer explanation when we get the exceptions.

@TurboTurtle TurboTurtle merged commit 509b460 into sosreport:main Oct 27, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants