Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insights] collect recursive listing of three dirs #3391

Merged

Conversation

pmoravec
Copy link
Contributor

Resolves: #3391
Closes: #3390


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@pmoravec pmoravec force-pushed the sos-pmoravec-insights-ls-collect branch from 11d0e0b to 48ec328 Compare October 20, 2023 11:16
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3391
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, two thoughts though.

  1. cmd_as_tag generates something like _bin_ls_[...] here, which is a bit odd to me, but perhaps it is fine since most tag consumers would be automation.
  2. We've seen a handful of these types of collection requests recently, would it be desirable to add a wrapper to standardize these? E.G. self.add_dir_listing(['dir1', 'dir2']), which collects ls with a standard set of options and a standard tag syntax?

Neither of these are blockers, point 2 is just food for thought at the moment, and if Insights is fine with the cmd_as_tag style, then all good.

@TurboTurtle TurboTurtle merged commit 48e3d0d into sosreport:main Oct 25, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required support for data collections within the sosreport
3 participants