Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nfs] remove duplicate rpcinfo_-p_localhost log #3394

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

yinoguchi
Copy link

@yinoguchi yinoguchi commented Oct 25, 2023

This commit removes the duplicate "rpcinfo_-p_localhost" log
from the sos_commands/nfs directory. Currently, the same log
file is being created in sos_commands/sunrpc/ directory,
as shown below:

  # ls sos_commands/nfs/rpcinfo_-p_localhost
  sos_commands/nfs/rpcinfo_-p_localhost
  # ls sos_commands/sunrpc/rpcinfo_-p_localhost
  sos_commands/sunrpc/rpcinfo_-p_localhost

Since rpcinfo command is included in rpcbind package, let's remove the one in the nfs directory.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

This commit removes the duplicate "rpcinfo_-p_localhost" log
from the sos_commands/nfs directory. Currently, the same log
file is being createdin sos_commands/sunrpc/ directory,
as shown below:

  # ls sos_commands/nfs/rpcinfo_-p_localhost
  sos_commands/nfs/rpcinfo_-p_localhost
  # ls sos_commands/sunrpc/rpcinfo_-p_localhost
  sos_commands/sunrpc/rpcinfo_-p_localhost

Since rpcinfo command is included in rpcbind package,
let's remove the one in the nfs directory.

Signed-off-by: Yuki Inoguchi <[email protected]>
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3394
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@jcastill jcastill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming here that there's no scenario where the NFS plugin will automatically run without the sunrpc one - i.e. an installation of nfs-utils that doesn't have rpcbind. If that's the case then ack from me.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a bead on which location people tend to look at first/most? Definitely in favor of the deduplication, but if most consumers are expecting this for nfs output, it may be best to keep it there and remove it from the other plugin.

@yinoguchi
Copy link
Author

Thank you for the review.

I'm not certain about which one people tend to look at first. However, in the current implementation, nfs.py depends on nfs-utils package, and sunrpc.py depends on rpcbind package. Since the rpcinfo command is included in rpcbind, I believe it is appropriate to leave it in sunrpc.py.

@TurboTurtle
Copy link
Member

Yep, that completely tracks. No complaints here.

@TurboTurtle TurboTurtle merged commit f2261a4 into sosreport:main Oct 28, 2023
34 checks passed
@yinoguchi yinoguchi deleted the remove_nfs_rpcinfo branch November 10, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants