-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nfs] remove duplicate rpcinfo_-p_localhost log #3394
Conversation
This commit removes the duplicate "rpcinfo_-p_localhost" log from the sos_commands/nfs directory. Currently, the same log file is being createdin sos_commands/sunrpc/ directory, as shown below: # ls sos_commands/nfs/rpcinfo_-p_localhost sos_commands/nfs/rpcinfo_-p_localhost # ls sos_commands/sunrpc/rpcinfo_-p_localhost sos_commands/sunrpc/rpcinfo_-p_localhost Since rpcinfo command is included in rpcbind package, let's remove the one in the nfs directory. Signed-off-by: Yuki Inoguchi <[email protected]>
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming here that there's no scenario where the NFS plugin will automatically run without the sunrpc one - i.e. an installation of nfs-utils that doesn't have rpcbind. If that's the case then ack from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a bead on which location people tend to look at first/most? Definitely in favor of the deduplication, but if most consumers are expecting this for nfs output, it may be best to keep it there and remove it from the other plugin.
Thank you for the review. I'm not certain about which one people tend to look at first. However, in the current implementation, |
Yep, that completely tracks. No complaints here. |
This commit removes the duplicate "rpcinfo_-p_localhost" log
from the sos_commands/nfs directory. Currently, the same log
file is being created in sos_commands/sunrpc/ directory,
as shown below:
Since rpcinfo command is included in rpcbind package, let's remove the one in the nfs directory.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines