[canonical-livepatch-onprem] Add Canonical Livepatch on-prem server support

[adam-vest]

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname [email protected]?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3418
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[jcastill]

lgtm, just a question: is there an api token or a user/pass we should obfuscate in this file?

[adam-vest]

There are both, actually - user credentials and a token that authenticates against upstream livepatch.. User password is already encoded, but perhaps not a bad idea to obfuscate. Is that something we'd do in the plugin directly, or elsewhere in sos?

[jcastill]

You can do it directly in the plugin itself. Here's an example of obfuscation in a yaml file:

https://github.com/sosreport/sos/blob/main/sos/report/plugins/juju.py#L65

[adam-vest]

Awesome, thanks for the link! I have some obfuscation code in now that looks like it's having the intended effect 🙂 I'll push once I get the simplification that Arif mentioned sorted out.

[arif-ali]

if you added services = ("livepatch-server") for the trigger at the top instead of files, then both the service status and the journal would be added by default, and then you will not need the 2 status checks and files

[adam-vest]

if you added services = ("livepatch-server") for the trigger at the top instead of files, then both the service status and the journal would be added by default, and then you will not need the 2 status checks and files

Hey @arif-ali , I tried doing the following as (I think you) suggested:

    services = ("livepatch-server")

    def setup(self):
        self.add_copy_spec([
            "/etc/livepatchd.yaml",
        ])

...but I didn't see the journal or service status in the resultant sos report? Normally these were appearing in sos_commands/canonical_livepatch_server. Is this new as of 4.6.0? I'm just testing against the version in apt, which is 4.5.6.

[TurboTurtle]

if you added services = ("livepatch-server") for the trigger at the top instead of files, then both the service status and the journal would be added by default, and then you will not need the 2 status checks and files

Hey @arif-ali , I tried doing the following as (I think you) suggested:

    services = ("livepatch-server")

    def setup(self):
        self.add_copy_spec([
            "/etc/livepatchd.yaml",
        ])

...but I didn't see the journal or service status in the resultant sos report? Normally these were appearing in sos_commands/canonical_livepatch_server. Is this new as of 4.6.0? I'm just testing against the version in apt, which is 4.5.6.

You're missing a comma in services to make it a tuple, rather than a string. services = ('livepatch-server',) The implicit collection for services was definitely in 4.5, but I forget exactly when we added it.

[adam-vest]

if you added services = ("livepatch-server") for the trigger at the top instead of files, then both the service status and the journal would be added by default, and then you will not need the 2 status checks and files

Hey @arif-ali , I tried doing the following as (I think you) suggested:

    services = ("livepatch-server")

    def setup(self):
        self.add_copy_spec([
            "/etc/livepatchd.yaml",
        ])

...but I didn't see the journal or service status in the resultant sos report? Normally these were appearing in sos_commands/canonical_livepatch_server. Is this new as of 4.6.0? I'm just testing against the version in apt, which is 4.5.6.

You're missing a comma in services to make it a tuple, rather than a string. services = ('livepatch-server',) The implicit collection for services was definitely in 4.5, but I forget exactly when we added it.

Awesome, got it! Thanks for the feedback - pushed an update to implement these things. Looking forward to any more feedback!

[TurboTurtle]

LGTM