[lvm2] Capture PV headers and metadata with pvck #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
arif-ali
approved these changes
Nov 30, 2023
sos/report/plugins/lvm2.py
Outdated
| @@ -39,6 +41,24 @@ def do_lvmdump(self, metadata=False): | |||
|
|
|||
| self.add_cmd_output(cmd, chroot=self.tmp_in_sysroot()) | |||
|
|
|||
| def get_pvck_output(self, metadata=False): | |||
There was a problem hiding this comment.
The metadata variable isn't being used, is that intentional for future work? and it's not being passed in setup() either 🤔
There was a problem hiding this comment.
It's a leftover from the first implementation. I'll remove it and push again.
Capture PV headers and metadata when a new option, lvm2.metadata , disabled by default, is specified as plugin option. Signed-off-by: Jose Castillo <[email protected]>
jcastill
force-pushed
the
jcastillo-add-pvck-headers
branch
from
55747e4
to
68888b8
Compare
arif-ali
approved these changes
Nov 30, 2023
TurboTurtle
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture PV headers and metadata when a new option, lvm2.metadata , disabled by default, is specified
as plugin option.
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines