Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discovery] collect also logs from container discovery-toolbox #3442

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jjansky1
Copy link
Contributor

@jjansky1 jjansky1 commented Dec 12, 2023

As part of the discovery is also discovery-toolbox plugin we should collect also logs from this plugin which may be helpful in debugging issues.

Resolves: #3442

Signed-off-by: Jan Jansky [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3442
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@jjansky1 jjansky1 force-pushed the jjansky1-discovery-toolbox branch from 811aa30 to b33443b Compare December 12, 2023 08:58
Copy link
Member

@jcastill jcastill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

As part of the discovery is also discovery-toolbox plugin
we should collect also logs from this plugin which may
be helpful in debugging issues.

Signed-off-by: Jan Jansky <[email protected]>
@jjansky1 jjansky1 force-pushed the jjansky1-discovery-toolbox branch from b33443b to ab79542 Compare December 12, 2023 13:14
@TurboTurtle TurboTurtle merged commit 14d5b74 into sosreport:main Dec 13, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants