Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sedutil.py] Added sedutil plugin to collect SED drives info #3460

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

BhushanSKale
Copy link
Contributor

@BhushanSKale BhushanSKale commented Jan 2, 2024

[sedutil.py] Added sedutil plugin to collect SED drives info
Now collecting Self Encrypting Drives info using sedutil utility
Signed-off-by: Bhushan Kale [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • [ X] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • [ X] Is the subject and message clear and concise?
  • [ X] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • [ X] Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3460
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@pmoravec
Copy link
Contributor

pmoravec commented Jan 2, 2024

To have the PR in merge-able state, please also squash the commits into one.

Copy link
Contributor

@pmoravec pmoravec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick responses!

It would be great to squash the two commitsinto one, otherwise ack from me.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, just a minor change.

sos/report/plugins/sedutil.py Outdated Show resolved Hide resolved
Now collecting Self Encrypting Drives info using sedutil utility
Signed-off-by: Bhushan Kale <[email protected]>
@TurboTurtle TurboTurtle merged commit d9aa743 into sosreport:main Jan 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants