-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vmware] Enable vmware plugin support on Ubuntu #3802
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
sos/report/plugins/vmware.py
Outdated
@@ -6,10 +6,10 @@ | |||
# | |||
# See the LICENSE file in the source distribution for further information. | |||
|
|||
from sos.report.plugins import Plugin, RedHatPlugin | |||
from sos.report.plugins import Plugin, RedHatPlugin, UbuntuPlugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm mistaken, I think you can add IndependentPlugin and remove RedHatPlugin to cover both distro families.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reply! I did test that and can confirm that it does work on Ubuntu, though wasn't seeing it working in Debian so didn't want to make a false impression. However, it seems that the version of sosreport in their repos predates the introduction of IndependentPlugin
entirely lol, so that was flawed testing on my end. So yes, I can agree that would likely be simpler in this case.
I'll see if I can adjust this commit without making a mess of things like last time heh...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry, most of us make a mess every now and then (and some of us pretty often :D)
If you need a hand, you can find us in libera irc network. If I'm online I'll be more than happy to help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arif-ali++
it looks perfect now, thank you!
sos/report/plugins/vmware.py
Outdated
|
||
|
||
class VMWare(Plugin, RedHatPlugin): | ||
class VMWare(Plugin, RedHatPlugin, UbuntuPlugin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as above, I think you can use IndependentPlugin as well
Signed-off-by: Adam Vest <[email protected]>
e40552c
to
634b959
Compare
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines
Howdy! In a recent case it came to my attention that this plugin wasn't triggering on Ubuntu systems on vmware estates. Since all the config files, commands, etc are all the same on Ubuntu as they are for RHEL, I gave it a quick test with these minor adjustments and found it to work swimmingly.
Let me know thoughts/opinions on this!