Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vmware] Enable vmware plugin support on Ubuntu #3802

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

adam-vest
Copy link
Contributor


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Howdy! In a recent case it came to my attention that this plugin wasn't triggering on Ubuntu systems on vmware estates. Since all the config files, commands, etc are all the same on Ubuntu as they are for RHEL, I gave it a quick test with these minor adjustments and found it to work swimmingly.

Let me know thoughts/opinions on this!

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3802
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@@ -6,10 +6,10 @@
#
# See the LICENSE file in the source distribution for further information.

from sos.report.plugins import Plugin, RedHatPlugin
from sos.report.plugins import Plugin, RedHatPlugin, UbuntuPlugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, I think you can add IndependentPlugin and remove RedHatPlugin to cover both distro families.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply! I did test that and can confirm that it does work on Ubuntu, though wasn't seeing it working in Debian so didn't want to make a false impression. However, it seems that the version of sosreport in their repos predates the introduction of IndependentPlugin entirely lol, so that was flawed testing on my end. So yes, I can agree that would likely be simpler in this case.

I'll see if I can adjust this commit without making a mess of things like last time heh...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, most of us make a mess every now and then (and some of us pretty often :D)
If you need a hand, you can find us in libera irc network. If I'm online I'll be more than happy to help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the offer @jcastill ! My colleague @arif-ali got me sorted and I just did a force-push to change it to IndependentPlugin 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arif-ali++
it looks perfect now, thank you!



class VMWare(Plugin, RedHatPlugin):
class VMWare(Plugin, RedHatPlugin, UbuntuPlugin):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as above, I think you can use IndependentPlugin as well

@TurboTurtle TurboTurtle merged commit b21be0b into sosreport:main Oct 8, 2024
36 checks passed
@adam-vest adam-vest deleted the vmware-ubuntu branch October 8, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants