Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP EDA] Collecting all log files from dir #3908

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

rbertol
Copy link
Contributor

@rbertol rbertol commented Jan 17, 2025

Changing the plugin to collect all log files from eda dir, it will avoid missing log files added to the product and not mapped at sos plugin.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • [x ] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • [ x] Is the subject and message clear and concise?
  • [ x] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • [ x] Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • [ x] Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3908
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

Is it worth having all-logs option as well, so by default you collect one of the logs, and if --all-logs is specified then you also collect the rotated logs?

        self.add_copy_spec("/etc/ansible-automation-platform/")
        if self.get_option("all_logs"):
            self.add_copy_spec([
                "/var/log/ansible-automation-platform/eda/",
                "/var/log/nginx/automationedacontroller.access.log*",
                "/var/log/nginx/automationedacontroller.error.log*",
            ])
        else:
            self.add_copy_spec([
                "/var/log/ansible-automation-platform/eda/*.log",
                "/var/log/nginx/automationedacontroller.access.log",
                "/var/log/nginx/automationedacontroller.error.log",
            ])

@arif-ali arif-ali added Status/Need More Info Feedback is required to reproduce issue or to continue work Kind/RedHat RedHat related item labels Jan 20, 2025
@rbertol rbertol force-pushed the fix-missing-log-files branch from 2e8a3ba to 70c0c53 Compare January 22, 2025 11:12
Changing the plugin to collect all log files from eda dir,
it will avoid missing log files added to the product
and not mapped at sos plugin.

Signed-off-by: Rudnei Bertol Junior <[email protected]>
@rbertol rbertol force-pushed the fix-missing-log-files branch from 70c0c53 to da9211d Compare January 22, 2025 11:24
@TurboTurtle TurboTurtle added the Reviewed/Ready for Merge Has been reviewed, ready for merge label Jan 25, 2025
@TurboTurtle TurboTurtle merged commit 7aed988 into sosreport:main Jan 25, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/RedHat RedHat related item Reviewed/Ready for Merge Has been reviewed, ready for merge Status/Need More Info Feedback is required to reproduce issue or to continue work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants