Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some routines to get background subtracted images #174

Merged
merged 28 commits into from
Dec 3, 2024
Merged

Add some routines to get background subtracted images #174

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a7230c6
Add some routines to get background subtracted images
jeanconn Aug 28, 2024
ab2a8f1
Break into more subroutines
jeanconn Sep 17, 2024
ee6086f
Add retry
jeanconn Sep 17, 2024
7a3290a
First round simplifications
jeanconn Sep 20, 2024
820211a
Second round simplifications
jeanconn Sep 24, 2024
f18ea88
Improve docstring and start/stop errors
jeanconn Sep 25, 2024
99361f1
Use default padding and smoothing in get_tccd_data
jeanconn Oct 21, 2024
f341fb4
Reorg and progress
jeanconn Nov 6, 2024
4080ac5
Move some imports to avoid circular issues
jeanconn Nov 19, 2024
f0d8d90
Add more docstrings
jeanconn Nov 20, 2024
84d95c3
Add more tests
jeanconn Nov 20, 2024
149c9c2
Update pre-commit config
jeanconn Nov 20, 2024
de58e09
Remove old import
jeanconn Nov 20, 2024
3edd838
Fix long line
jeanconn Nov 20, 2024
f263a89
Minor renaming and doc improvements from feedback
jeanconn Nov 25, 2024
71eb86a
Fix some mica -> cxc pieces
jeanconn Nov 25, 2024
b3f58b1
Be more strict about bounds
jeanconn Nov 25, 2024
81bc8f9
Remove unmasking as no longer needed
jeanconn Nov 27, 2024
5cba36b
Wrong type in docstring
jeanconn Nov 27, 2024
6e20ccf
Add some handling for zero length img_table
jeanconn Nov 27, 2024
9b79677
Change shapes for zero-length output
taldcroft Dec 2, 2024
28625f4
Update tests (now failing)
taldcroft Dec 2, 2024
07d1c35
Docstring updates
taldcroft Dec 2, 2024
4a8a73c
Update dark map extraction to be per-pixel to work near edges
jeanconn Dec 2, 2024
3ea9707
Update test to work at positive ccd edges
jeanconn Dec 2, 2024
45e0108
Pre-ruff formatting fix
jeanconn Dec 2, 2024
4c87665
Oops, edge at -512
jeanconn Dec 2, 2024
37560e5
Move the numba function to module scope
taldcroft Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chandra_aca/tests/test_aca_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,8 +524,8 @@ def images_check_range(start, stop, img_table, *, bgsub):
row8x8 = row["IMGROW0_8X8"]
col8x8 = row["IMGCOL0_8X8"]

# If row8x8 or col8x8 is < 0 just skip the test for now
if row8x8 < 0 or col8x8 < 0:
# If row8x8 or col8x8 is < -512 just skip the test for now
if row8x8 < -512 or col8x8 < -512:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I have an update to handle the "off the negative CCD edges", but I don't think that we can get real data like that at all, so maybe there is no point.

continue

dark_ref = full_img_dark.aca[row8x8 : row8x8 + 8, col8x8 : col8x8 + 8]
Expand Down
Loading