Fix issue setting the lookback default after it gets used #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #351 introduced a problem in kadi commands update processing where the lookback value (None by default) was being used in a computation prior to being set to the
conf.default_lookback
value. This was temporarily fixed in production by adding the--lookback=30
flag to the script command.This PR does two things:
lookback
update to the top of the function before it gets used.--lookback
argument. This matches the way the script is called in production.This PR also includes an unrelated fix for ruff 11.0. There are no code changes so I did not re-run unit tests.
Interface impacts
None
Testing
Unit tests
With only the 1st commit, the
test_commands_create_archive_regress
test fails with the same exception seen in production processing.With both commits:
Independent check of unit tests by Javier (also ran test after reverting 76c8551 to make sure the test would have caught the issue).
Functional tests
No functional testing.