Update to allow version check to work with php 8 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead"
|
@timhaak Thanks for this contribution! The CI is failing, could you please take a look? |
|
Is this PR whiling to resolve #74? |
|
Just a bit to busy to sort this out now. Will do a new pull request with fixes when/if I catch up a bit :) |
pelmered
reviewed
Nov 29, 2020
Comment on lines
+52
to
+58
| if (Comparator::compare($p1->getVersion(), '=', $p2->getVersion())) { | ||
| return 0; | ||
| } | ||
| if (Comparator::compare($p1->getVersion(), '<', $p2->getVersion())) { | ||
| return 1; | ||
| } | ||
| return -1; |
There was a problem hiding this comment.
I would replace with ternary:
return Comparator::compare($p1->getVersion(), '<', $p2->getVersion()) ? 1 : -1;
There shouldn't be any versions that are equal, right?
kohenkatz
added a commit
to kohenkatz/composer-versions-check
that referenced
this pull request
Oct 1, 2021
According to the documentation, all versions of PHP support the `usort` callable parameter returning an `integer`. While earlier versions silently accepted a `boolean`, PHP 8.x throws a deprecation notice: ``` Deprecation Notice: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in C:\Users\MY_USER\AppData\Roaming\Composer\vendor\sllh\composer-versions-check\src\VersionsCheck.php:54 ``` This fix (based on [this comment](soullivaneuh#75 (comment))) eliminates this notice. fixes soullivaneuh#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to start getting things to work with PHP 8.0
Also fixed the PHPUnit deprecation warning.