-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 81 onsnapshot #130
base: master
Are you sure you want to change the base?
Issue 81 onsnapshot #130
Conversation
…aChanges is true.
…l the onSnapshot callbacks no mater where the flush is called from.
This is great, I'm glad I found this because I really needed this functionality in tests, however in it's current state I don't think it'll quite work yet. The functionality missing (or not quite working) is that:
I think 2 is more related to a fundamental issue with this mocking library in that |
@derekparker I updated this to return both immediately and when something changes. I'm not sure then where operator is fully implemented. |
These changes work well in my project. Is there a reason this PR hasn't been able to be merged yet? EDIT: Nevermind, I did notice an issue with the code: the onSnapshot callback sometimes wasn't called with the initial contents (if value was null at the time, or if called on a dec-ref instead of a query). Created a new pull-request which resolves those issues: #158 |
Implements onSnapshot. See #81