Implementation of typings into sdk for Typescript #99
+242
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry that this wasn't approved and merged. I'm using this via copy-and-paste and it works well so far. |
erykpekala
reviewed
Aug 10, 2021
| @@ -23,13 +23,15 @@ module.exports = function(scaudioPlayer) { | |||
| let timerId = 0; | |||
| let previousPosition = null; | |||
| scaudioPlayer.onChange.subscribe(({ playing, seeking, dead }) => { | |||
| if (!window) return; | |||
erykpekala
reviewed
Aug 10, 2021
| if (dead) { | ||
| window.clearTimeout(timerId); | ||
| } else if (playing !== undefined || seeking !== undefined) { | ||
| doEmit(); | ||
| } | ||
| }); | ||
| function doEmit() { | ||
| if (!window) return; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to answer to #69
Implementation may not be as usual, it's nested into the repo and referenced by the
package.json.Other packages implement typings at DefinitelyTyped.
The file
index.d.tsinto the foldertypes/soundcloudshould be available at base directory of the npm package, next tosdk.js.