Insert validation that token divider must be > 0

source-academy · Nov 16, 2023 · 4537fc0 · 4537fc0
1 parent 2b648c3
commit 4537fc0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/cadet/assessments/question_types/voting_question.ex b/lib/cadet/assessments/question_types/voting_question.ex
@@ -21,5 +21,6 @@ defmodule Cadet.Assessments.QuestionTypes.VotingQuestion do
     question
     |> cast(params, @required_fields ++ @optional_fields)
     |> validate_required(@required_fields)
+    |> validate_number(:token_divider, greater_than: 0)
   end
 end
diff --git a/test/cadet/assessments/question_types/voting_question_test.exs b/test/cadet/assessments/question_types/voting_question_test.exs
@@ -23,6 +23,26 @@ defmodule Cadet.Assessments.QuestionTypes.VotingQuestionTest do
         },
         :invalid
       )
+
+      assert_changeset(
+        %{
+          content: "content",
+          contest_number: "C3",
+          reveal_hours: 48,
+          token_divider: -1
+        },
+        :invalid
+      )
+
+      assert_changeset(
+        %{
+          content: "content",
+          contest_number: "C6",
+          reveal_hours: 48,
+          token_divider: 0
+        },
+        :invalid
+      )
     end
   end
 end