Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests failing on some random seeds #1004

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix tests failing on some random seeds #1004

merged 1 commit into from
Sep 20, 2023

Conversation

kjw142857
Copy link
Contributor

Modify assertion in #1002 - testing for fetching of valid contest questions to check for permutations instead of a direct ==.

@RichDom2185 RichDom2185 changed the title Minor fix for #1002 - Modification of test Fix tests failing on some random seeds Sep 20, 2023
RichDom2185
RichDom2185 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this so quickly!

@RichDom2185 RichDom2185 enabled auto-merge (squash) September 20, 2023 06:23
@coveralls
Copy link

Coverage Status

coverage: 95.408%. remained the same when pulling a5069fc on kjw142857:master into b2422a4 on source-academy:master.

@RichDom2185 RichDom2185 merged commit dcecb49 into source-academy:master Sep 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjw142857 @coveralls @RichDom2185