Set whether stories is enabled in course config #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
commented
Jan 16, 2024
There was a problem hiding this comment.
@YaleChen299 since the config change is a relatively passive thing, I don't see the need to add more tests when the views are effectively identical. Can I get your thoughts on this? Thanks!
7 tasks
YaleChen299
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A backwards-compatible change thus can be merged independently of the frontend (associated frontend PR TBC).
This aims to allow the frontend, which first retrieves the course config from the main backend, to also check if it should then ping the stories backend.
This would solve the spurious 404 errors when stories is not enabled for a particular course.