Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Assessment Configurability in Ground Control #1093

Merged
merged 18 commits into from
Mar 26, 2024
Merged

Improved Assessment Configurability in Ground Control #1093

merged 18 commits into from
Mar 26, 2024

Conversation

DesSnowy
Copy link
Contributor

This pull request supports user to configure assessment setting per assessment. This allows better control of each individual assessments and which features they have.

Changes to be made:

  • Added "hasTokenCounter" and "hasVotingFeatures" to assessments
  • Added "hasVotingFeatures" to assessmentConfig
  • "hasTokenCounter" and "hasVotingFeatures" will be initialised to the respective value in assessmentConfig when the assessment is uploaded
  • Changed output to show settings of individual assessments
  • Updated test case to match

DesSnowy added 11 commits March 20, 2024 23:39
@DesSnowy
rename hasTokenCounter to hasVotingFeature under assessmentConfig
2da5101
@DesSnowy
Added hasVotingFeatures to assessment config
fe7854c
@DesSnowy
Added hasVotingFeature to assessmentConfig
d2bfd92
@DesSnowy
Added hasTokenCounter and hasVotingFeatures to assessments
cb18e73
@DesSnowy
hasTokenCounter and hasVotingFeatures to be updated to ones in assess…
6012b11 
…ment config when uploaded
@DesSnowy
Added hasTokenCounter and hasVotingFeatures to be shown when assessme…
ade5541 
…nt is requested
@DesSnowy
Added hasTokenCounter into swaggers
284da06
@DesSnowy
Changed test cases to include hasVotingFeatures and hasTokenCounter
96d1dc7
@DesSnowy
Added a way to change hasTokenCounter and hasVotingFeatures from the …
9687930 
…frontEnd
@DesSnowy
fixed format
0bc2486
@DesSnowy
Merge branch 'source-academy:master' into RenameHasTokenCounterToHasV…
6c5f9e6 
…otingFeatures
@DesSnowy
Copy link
Contributor Author

Corresponding frontend PR: source-academy/frontend#2863

@DesSnowy DesSnowy mentioned this pull request Mar 22, 2024
Merged
2 tasks
DesSnowy added 3 commits March 22, 2024 21:59
@DesSnowy
fixed format
394cb52
@DesSnowy
fixed alias format
49ac07d
@DesSnowy
Merge branch 'RenameHasTokenCounterToHasVotingFeatures' of github.com…
4c059eb 
…:DesSnowy/source-academy-backend into RenameHasTokenCounterToHasVotingFeatures
@coveralls
Copy link

coveralls commented Mar 22, 2024 •
edited
Loading

Coverage Status

coverage: 95.505% (+0.02%) from 95.487%
when pulling b7dda28 on DesSnowy:RenameHasTokenCounterToHasVotingFeatures
into 5edaa6a on source-academy:master.

RichDom2185
RichDom2185 reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, thanks!

lib/cadet_web/admin_controllers/admin_assessments_controller.ex Outdated Show resolved Hide resolved
RichDom2185
RichDom2185 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185 RichDom2185 merged commit b410b5f into source-academy:master Mar 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

@sayomaki sayomaki Awaiting requested review from sayomaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DesSnowy @coveralls @RichDom2185