Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting for grading #1107

Merged
merged 29 commits into from
Aug 19, 2024
Merged

Add sorting for grading #1107

merged 29 commits into from
Aug 19, 2024

Conversation

thortol
Copy link
Contributor

@thortol thortol commented Apr 8, 2024 •
edited by InfinityTwo
Loading

Description

To be merged with Frontend #2893

For implementation decisions, see Frontend PR.

Changes

  • Changed submissions_by_grader_for_index pipeline by adding user table, assessment.title and assessment.config_id
  • Added sort_submission to sort the query in the pipeline

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Apr 8, 2024 •
edited
Loading

Coverage Status

coverage: 94.378% (-0.3%) from 94.68%
when pulling 842cef1 on thortol:add-sorting-for-grading
into 76cb9f7 on source-academy:master.

@InfinityTwo InfinityTwo mentioned this pull request Apr 8, 2024
Merged
12 tasks
@RichDom2185
Copy link
Member

Is this PR ready?

@thortol thortol marked this pull request as ready for review April 14, 2024 10:35
@InfinityTwo InfinityTwo requested a review from RichDom2185 April 15, 2024 09:35
RichDom2185
RichDom2185 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) August 19, 2024 08:32
@RichDom2185
Copy link
Member

Sorry for the delayed review…

@RichDom2185
Revert "Prefer piping"
842cef1 
This reverts commit 415cdc0.
@RichDom2185 RichDom2185 disabled auto-merge August 19, 2024 08:35
@RichDom2185 RichDom2185 enabled auto-merge (squash) August 19, 2024 08:35
@RichDom2185 RichDom2185 merged commit ddd4378 into source-academy:master Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thortol @coveralls @RichDom2185 @InfinityTwo @lhw-1