-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Team Assessments #968
Add Team Assessments #968
Conversation
Branch add team size
…to pr/CheongYeeMing/968
…to pr/CheongYeeMing/968
To ensure proper ordering
…to pr/CheongYeeMing/968
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment for now (reviewed ~ half the files):
team_members | ||
|> Enum.map(fn team_member -> | ||
users |> Enum.find(&(&1.id == team_member.student_id)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realised this results in an n+1
query problem. We should use a join instead to keep it to O(1) total queries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, on second thought, should be fine as there are no team members for now, but we might want to look at it again in the future. Will file an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Source Academy - Team Assessments Module
This is the PR for the MVP of integrating Team Assessments into the existing Source Academy. Collaboration among students in coursework through the implementation of this collaborative module offers immense benefits and serves as a powerful motivation for its adoption. By providing students with the option to collaborate, share ideas, and work together on assessments, projects, and discussions, they can tap into a diverse range of perspectives and insights.
To be completed:
Notes: