Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oban from 2.15.2 to 2.15.4 #982

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 8, 2023

Bumps oban from 2.15.2 to 2.15.4.

Release notes

Sourced from oban's releases.

v2.15.3

Enhancements

  • [Pruner] Prune jobs using the scheduled_at timestamp regardless of state.

    The previous pruning query checked a different timestamp field for each prunable state, e.g. cancelled used cancelled_at. There aren't any indexes for those timestamps, let alone the combination of each state and timestamp, which led to slow pruning queries in larger databases.

    In a database with a mixture of ~1.2m prunable jobs the updated query is 130x faster, reducing the query time from 177ms down to 1.3ms.

  • [Lite] Avoid unnecessary transactions during staging and pruning operations

    Contention between SQLite3 transactions causes deadlocks that lead to period errors. Avoiding transactions when there isn't anything to write minimizes contention.

Bug Fixes

  • [Foreman] Explicitly pause queues when shutdown begins.

    A call to Producer.shutdown/1 was erroneously removed during the DynamicSupervisor queue refactor.

  • [Job] Preserve explicit state set along with scheduled_in time.

    The presence of a scheduled_in timestamp would always set the state to scheduled, even when an explicit state was passed.

Changelog

Sourced from oban's changelog.

v2.15.4 — 2023-08-07

Enhancements

  • [Testing] Accept all config options in perform_job/3

    Testing with perform_job/3 requires building a viable config object. Previously, only a few select options like repo were forwarded, which hampered the ability to tweak config for testing.

Bug Fixes

  • [PG] Remove monitored processes from listeners list

    The PG notifier monitored listener processes but didn't remove them from the set when a listener exited. Busy systems would gradually accumulate dead pids and kept dispatching to them, bottlnecking the PG process and eventually calling timeouts for new listeners.

v2.15.3 — 2023-08-04

Enhancements

  • [Pruner] Prune jobs using the scheduled_at timestamp regardless of state.

    The previous pruning query checked a different timestamp field for each prunable state, e.g. cancelled used cancelled_at. There aren't any indexes for those timestamps, let alone the combination of each state and timestamp, which led to slow pruning queries in larger databases.

    In a database with a mixture of ~1.2m prunable jobs the updated query is 130x faster, reducing the query time from 177ms down to 1.3ms.

  • [Lite] Avoid unnecessary transactions during staging and pruning operations

    Contention between SQLite3 transactions causes deadlocks that lead to period errors. Avoiding transactions when there isn't anything to write minimizes contention.

Bug Fixes

  • [Foreman] Explicitly pause queues when shutdown begins.

    A call to Producer.shutdown/1 was erroneously removed during the DynamicSupervisor queue refactor.

  • [Job] Preserve explicit state set along with scheduled_in time.

    The presence of a scheduled_in timestamp would always set the state to scheduled, even when an explicit state was passed.

Commits
  • 8acfe4d Release v2.15.4
  • 9b3da77 Accept all config options in perform_job/3
  • a2c5093 Format oban module to fix extra whitespace
  • 207b8e9 Remove monitored processes from listeners list
  • 6e12c98 Release v2.15.3
  • a11497a Document error behavior for Oban.insert_all/3 (#934)
  • 64b998d Fix module typo in the migration doc. (#929)
  • e77931b More accurately describe Oban.retry_all_jobs/2
  • c96465d Do not start a write transaction when there is nothing to write (#924)
  • 9f6e526 Fix "Features" anchor in README.md (#925)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@coveralls
Copy link

Coverage Status

coverage: 95.398% (+0.04%) from 95.358% when pulling 5e41525 on dependabot/hex/oban-2.15.4 into 5d09b51 on master.

@RichDom2185
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/hex/oban-2.15.4 branch 2 times, most recently from 9ffc560 to 908556c Compare September 3, 2023 07:11
@RichDom2185 RichDom2185 enabled auto-merge (squash) September 3, 2023 07:12
Bumps [oban](https://github.com/sorentwo/oban) from 2.15.2 to 2.15.4.
- [Release notes](https://github.com/sorentwo/oban/releases)
- [Changelog](https://github.com/sorentwo/oban/blob/v2.15.4/CHANGELOG.md)
- [Commits](oban-bg/oban@v2.15.2...v2.15.4)

---
updated-dependencies:
- dependency-name: oban
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/hex/oban-2.15.4 branch from 908556c to 01ff66d Compare September 3, 2023 07:16
@RichDom2185
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 3, 2023

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@RichDom2185 RichDom2185 merged commit dfcbdb4 into master Sep 3, 2023
@dependabot dependabot bot deleted the dependabot/hex/oban-2.15.4 branch September 3, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants