-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix load times #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I just have the minor comments below:
ctowasm/.gitignore
Outdated
@@ -5,3 +5,6 @@ output | |||
node_modules | |||
test/temp | |||
.parcel-cache | |||
src/parser/peggyjs/preprocessor.js | |||
src/parser/peggyjs/lexer.js | |||
src/parser/peggyjs/parser.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a blank line at the end of this file?
@@ -0,0 +1 @@ | |||
export function parse(input: string): string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes the slow load times experienced on Source Academy by moving the generation of peggy js parsers to build time.