Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load times #3

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Fix load times #3

merged 5 commits into from
Apr 18, 2024

Conversation

benmurphyy
Copy link
Contributor

Fixes the slow load times experienced on Source Academy by moving the generation of peggy js parsers to build time.

@benmurphyy benmurphyy added the bug Something isn't working label Apr 17, 2024
@benmurphyy benmurphyy requested a review from martin-henz April 17, 2024 11:53
@benmurphyy benmurphyy self-assigned this Apr 17, 2024
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I just have the minor comments below:

@@ -5,3 +5,6 @@ output
node_modules
test/temp
.parcel-cache
src/parser/peggyjs/preprocessor.js
src/parser/peggyjs/lexer.js
src/parser/peggyjs/parser.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a blank line at the end of this file?

@@ -0,0 +1 @@
export function parse(input: string): string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@benmurphyy benmurphyy requested a review from RichDom2185 April 18, 2024 04:03
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@martin-henz martin-henz merged commit 940ab37 into main Apr 18, 2024
2 checks passed
@martin-henz martin-henz deleted the fix-load-times branch April 18, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants