Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure emscripten modules for web environment #5

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

benmurphyy
Copy link
Contributor

Linked to source-academy/frontend#2996.
Should fix the following issue:
Screenshot 2024-07-05 at 5 51 30 PM

Unable to test fully on the deployed frontend due to other errors present with the changes relating to vite migration.

@benmurphyy benmurphyy requested a review from martin-henz July 5, 2024 09:52
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 4a4e15a into main Jul 7, 2024
2 checks passed
@RichDom2185 RichDom2185 deleted the configure-emscripten-modules-for-web branch July 7, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants