Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up team assessments #2875

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Clean up team assessments #2875

merged 8 commits into from
Mar 26, 2024

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Mar 25, 2024

Description

To rebase and force-push following the merge of #2548.

Breaking change by technicality.

Summary of changes:

  • Cleans up some unnecessary styles
  • Reverts Ground Control back to AG Grid
  • Remove ground control and team formation from "workspaces"
  • Favor Blueprint components over custom ones

More cleanup will be done in the future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Mar 25, 2024
@coveralls
Copy link

coveralls commented Mar 25, 2024

Pull Request Test Coverage Report for Build 8436849250

Details

  • 0 of 24 (0.0%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 35.312%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/groundControl/GroundControlContainer.ts 0 1 0.0%
src/pages/academy/teamFormation/subcomponents/TeamFormationDashboard.tsx 0 1 0.0%
src/pages/academy/teamFormation/subcomponents/TeamFormationForm.tsx 0 1 0.0%
src/pages/academy/teamFormation/subcomponents/TeamFormationActions.tsx 0 3 0.0%
src/pages/academy/teamFormation/subcomponents/TeamFormationTable.tsx 0 3 0.0%
src/pages/academy/groundControl/GroundControl.tsx 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/groundControl/GroundControl.tsx 1 0.0%
Totals Coverage Status
Change from base Build 8436818871: 0.06%
Covered Lines: 5089
Relevant Lines: 13441

💛 - Coveralls

But also retained the functional component aspect.
Favors the use of Blueprint components over custom components and styles
for a more consistent user interface.
The filters never belonged there in the first place as it is not a
workspace.

The functionality is not restored as we will be moving back to AG Grid
for tables.
@RichDom2185 RichDom2185 force-pushed the clean-up-team-assessments branch from 5b4803f to f8e4ba9 Compare March 26, 2024 13:31
@RichDom2185 RichDom2185 marked this pull request as ready for review March 26, 2024 13:31
Copy link
Member Author

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't approve my own PR, though, LGTM – as per offline discussions.

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@RichDom2185 RichDom2185 merged commit c160a10 into master Mar 26, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the clean-up-team-assessments branch March 26, 2024 13:45
@RichDom2185 RichDom2185 mentioned this pull request Mar 26, 2024
7 tasks
izruff pushed a commit that referenced this pull request Apr 2, 2024
* Migrate Ground Control back to AG-Grid

But also retained the functional component aspect.

* Delete unused component

* Use selectors for Ground Control state

* Remove ground control from file system

* Remove unnecessary styles

Favors the use of Blueprint components over custom components and styles
for a more consistent user interface.

* Remove remaining traces of old Ground Control

* Fix format

* Remove team formation from workspace slice

The filters never belonged there in the first place as it is not a
workspace.

The functionality is not restored as we will be moving back to AG Grid
for tables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants