Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed bug where grading editor could not open #2888

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fixed bug where grading editor could not open #2888

merged 1 commit into from
Mar 29, 2024

Conversation

thortol
Copy link
Contributor

@thortol thortol commented Mar 29, 2024

Description

fixed a bug where grading editor could not be open
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Go to grading page and click on the grade button for any submission, the grading editor will be able to open now.

Checklist

  • I have tested this code
  • I have updated the documentation

@thortol thortol requested a review from RichDom2185 March 29, 2024 10:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8479921941

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 35.231%
Totals Coverage Status
Change from base Build 8466767804: 0.0%
Covered Lines: 5119
Relevant Lines: 13567
💛 - Coveralls

@RichDom2185
Copy link
Member

This regression was caused by #2548

RichDom2185
RichDom2185 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 227edff into source-academy:master Mar 29, 2024
6 checks passed
izruff pushed a commit that referenced this pull request Apr 2, 2024
@thortol @izruff
fixed bug where grading editor could not open (#2888)
e3185d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thortol @coveralls @RichDom2185