Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of logos for new login page for Firefox browsers #3051

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

sayomaki
Copy link
Contributor

Description

This PR primarily aims to improve the design and placement of the logos on the new login page to be more centered. Also address a small positioning problem with Firefox browsers on the login page.

I have tested the code to ensure no regressions in terms of logo display, and that it renders consistently across different screen resolutions and sizes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Ensure new login page displays logo centered on Chromium-based browsers, and for Firefox that the logo is no longer out of position.

Checklist

  • I have tested this code
  • I have updated the documentation

@sayomaki sayomaki self-assigned this Sep 22, 2024
@coveralls
Copy link

coveralls commented Sep 22, 2024

Pull Request Test Coverage Report for Build 11650605557

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.319%

Totals Coverage Status
Change from base Build 11568075789: 0.0%
Covered Lines: 4833
Relevant Lines: 14557

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Thanks for fixing this! Possible to make it so that when it's a small screen, it becomes centre-aligned instead of space between?

@sayomaki sayomaki enabled auto-merge (squash) September 24, 2024 07:00
@sayomaki sayomaki requested a review from RichDom2185 November 3, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants