Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI and ESLint configuration #241

Closed
wants to merge 45 commits into from
Closed

Update CI and ESLint configuration #241

wants to merge 45 commits into from

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Sep 10, 2023 •
edited
Loading

Description

  • Update PR template
  • Update CI to run lint checks
  • Typecheck ESLint config
    • Uses JSDoc comments to allow for editor auto-completions
  • Clean up ESLint config
  • Remove Airbnb ESLint config
    • Most cases are covered by typescript-eslint, and no point downgrading the other cases to a warning anyway
  • Set up Prettier config
  • Install Prettier
    • It's opinionated, but as a result, has minimal configuration and also is consistent with frontend

Type of change

  • Code quality improvements

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@RichDom2185 RichDom2185 self-assigned this Sep 10, 2023
@Cloud7050 Cloud7050 mentioned this pull request Sep 11, 2023
Merged
@RichDom2185 RichDom2185 mentioned this pull request Feb 17, 2024
Merged
6 tasks
@RichDom2185
Update some ESLint configs
f237379
@RichDom2185
Autofix some ESLint errors
cb1a8ac
@RichDom2185
Autofix more ESLint errors
aee8463
@RichDom2185
Simplify base ESLint config
18bdaa2 
Reduces complexity of the codebase.
@RichDom2185
Remove AirBnB config
67152b5 
Most cases are already covered by typescript-eslint, and there's no
point adding the additional rules only to downgrade them later.
@RichDom2185
Reformat some files using Prettier
477c8eb 
Also updated Prettier config
@RichDom2185
Revert trailing comma config to 'none'
4ac3ff7
@RichDom2185
Simplify ESLint config
9d80c1d 
We will enforce the rules using Prettier later.
@RichDom2185
Reformat tabs with prettier
5e81f49
@RichDom2185
Add ignore for bugfix
87afbf7
@RichDom2185
Reformat more files
3abc31c
@RichDom2185
Reformat some bundle files with prettier
423fb9a 
Also did some manual reformatting for readability.
@RichDom2185
Reformat some more files
103e37c
@RichDom2185
Fix ESLint configs
f4cc696
@RichDom2185
Reformat more bundles using Prettier
c730009
@RichDom2185
Fix ESLint errors in bundles and tabs
a6b77f9 
Also reformatted some files in the process.
@RichDom2185
Update devserver lint config
e60b603
@RichDom2185
Fix lint in devserver
0f58149 
Also reformatted the workspace.
@RichDom2185
Reformat devserver
236a757
@RichDom2185 RichDom2185 removed the request for review from Cloud7050 February 18, 2024 02:38
@RichDom2185 RichDom2185 marked this pull request as ready for review February 18, 2024 02:38
@RichDom2185 RichDom2185 requested a review from sayomaki February 18, 2024 03:09
@RichDom2185
Copy link
Member Author

Adding @sayomaki for suggestions – refer to the original discussion in #275. What are your thoughts?

RichDom2185
RichDom2185 commented Feb 18, 2024
View reviewed changes
Copy link
Member Author

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this PR is marked as "ready" for interim/RFC purposes, cleaning up will be done later (or perhaps in a subsequent PR to minimise the changes to this PR)

@RichDom2185
Copy link
Member Author

Superseded by #296

@RichDom2185 RichDom2185 deleted the update-ci branch March 26, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeyi45 leeyi45 Awaiting requested review from leeyi45

@sayomaki sayomaki Awaiting requested review from sayomaki

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RichDom2185