Switched to Microsoft.VisualStudio.Language v17.6.268 - Autocomplete compatibility fix part 1 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiotrKarczmarz
changed the title
PiotrKarczmarz
changed the title
PiotrKarczmarz
added a commit
that referenced
this pull request
Jan 21, 2025
Autocomplete loads and initialize via MEF independently from the main extension. It allows to avoid extension crashes in Visual Studio versions below 17.6, which doesn't support using `Microsoft.VisualStudio.Language` library, more precisely `Microsoft.VisualStudio.Threading` v17.6 (check #198). If the current VS version supports `Microsoft.VisualStudio.Language`, `Cody.VisualStudio.Completions.dll` will be silently loaded via MEF. Otherwise, `Cody.VisualStudio.Completions.dll` won't be loaded, but the main extension will be working. In the future, if Visual Studio will introduce breaking changes to Microsoft.VisualStudio.Language API, the main extension with chat will still be working, but autocomplete will be silently turned off. It was tested against VS versions: 17.7.6 17.9 Preview 2 17.10.3 17.12 17.13.0 Preview 2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocomplete compatibility fix allowing to support autocomplete starting from Visual Studio VS 17.6+
It was tested against VS versions:
Internally
Microsoft.VisualStudio.Languageversion is set to 17.0.0.0 after compilation, regardless ofMicrosoft.VisualStudio.Languageversion used as nuget package. The important part isMicrosoft.VisualStudio.Threadinglibrary, which version set explicitly to match nugetMicrosoft.VisualStudio.Languageversion.Test plan