Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volumeMounts option for frontend init container #387

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

jdpleiness
Copy link
Contributor

@jdpleiness jdpleiness commented Dec 21, 2023

Allow for volumeMounts in the frontend init container.

  • Allows mounting TLS certificates needed to establish encrypted TLS connections to PostgreSQL databases.

Values can be set in a override file as follows:

frontend:
  extraVolumes:
  - name: migrator-tls
    secret:
      secretName: migrator-tls-secret

migrator:
  extraVolumeMounts:
  - name: migrator-tls
    mountPath: /etc/tls
    readOnly: true
  env:
    PGSSLCERT:
      value: /etc/tls/tls.crt
    PGSSLKEY:
      value: /etc/tls/tls.key

Checklist

Test plan

Manual test and Helm lint

@jdpleiness jdpleiness marked this pull request as ready for review December 21, 2023 17:37
Copy link
Member

@michaellzc michaellzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we port this change to the sourcegraph-migrator chart as well?

@jdpleiness jdpleiness merged commit f0d843e into main Dec 21, 2023
3 checks passed
@jdpleiness jdpleiness deleted the jdp/frontend-init-tls branch December 21, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants