fix(sourcegraph): do not render SSLMODE twice for grafana sts #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellzc
force-pushed
the
01-24-fix_sourcegraph_do_not_render_sslmode_twice_for_grafana_sts
branch
from
02c7117 to
32d462c
Compare
|
also #617 is technically a breaking change for those using existing secrets in the overrides, it will break in next deployment |
filiphaftek
approved these changes
Jan 24, 2025
michaellzc
deleted the
01-24-fix_sourcegraph_do_not_render_sslmode_twice_for_grafana_sts
branch
3 tasks
michaellzc
added a commit
that referenced
this pull request
Jan 25, 2025
…afana sts (#628) regression from #617 it's now rendering `_SSLMODE` twice in the grafana sts ### Checklist - [ ] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [ ] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [ ] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes) ### Test plan CI <br> Backport bb2d4f1 from #627 Co-authored-by: Michael Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression from #617
it's now rendering
_SSLMODEtwice in the grafana stsChecklist
Test plan
CI