Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search-jobs: update defaults #895

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

stefanhengl
Copy link
Member

The defaults were changed in sourcegraph/zoekt#850.

Test plan:
N/A

The defaults were changed in sourcegraph/zoekt#850.

Test plan:
N/A
@stefanhengl stefanhengl requested a review from a team January 14, 2025 12:29
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:31am

Copy link
Member

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nitpick: should the PR title say search: update shard merging defaults? Feels unrelated to search jobs.

@stefanhengl stefanhengl merged commit 23229a0 into main Jan 15, 2025
5 checks passed
@stefanhengl stefanhengl deleted the sh/search-jobs/update-defaults branch January 15, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants