This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
Fix Notion migrations not working in when served by Netlify. #8960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found why the redirections are not working in prod. In local, NextJS handles the redirections (logical), but in prod, we let Netlify do it (logical, as it's serving static content).
But, the semantics in between the two are not the same:
So the fix was to patch the code that generates the
_redirects
file that Netlify needs, to add the301!
in/source https://where 301!
required for it to stop ignoring those.I really didn't see coming the different semantics here :/