Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pnpm #219

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Add support for pnpm #219

merged 4 commits into from
Jan 6, 2023

Conversation

valerybugakov
Copy link
Member

Context

This PR adds support for pnpm workspaces. We're switching to pnpm to simplify our integration with Bazel. See the tracking issue for more context:

Test plan

  1. Checkout to vb/pnpm-test-3 in the Sourcegraph monorepo.
  2. rm -rf node_modules ./client/*/node_modules && pnpm install
  3. DIR=/path/to/scip-typescript; "$DIR/node_modules/.bin/ts-node" "$DIR/src/main.ts" index --pnpm-workspaces

@valerybugakov
Copy link
Member Author

Looks like the CI / test (18.x) job fails in other PRs not related to the package logic too.

@olafurpg
Copy link
Member

olafurpg commented Jan 6, 2023

We can add an integration test by adding a pnpm project under snapshots/input and make sure to enable the new --pnpm-workspaces flag here

yarnWorkspaces: Boolean(packageJson.workspaces),

@valerybugakov
Copy link
Member Author

@olafurpg, added 56506ad 👍

@valerybugakov
Copy link
Member Author

And fixed the issue with the CI / test (18.x) job.

@valerybugakov valerybugakov merged commit 3736a13 into main Jan 6, 2023
@valerybugakov valerybugakov deleted the vb/support-pnpm-workspaces branch January 6, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants