Implement enclosing ranges #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Titou325
changed the title
|
super glad this is being built! |
|
Apologies for missing this PR earlier, I will review this PR on Monday. For future PRs, please feel free to ping me directly. |
This was referenced Dec 25, 2023
|
Overall, this PR looks quite good. I've broken it up into smaller PRs, and made some minor adjustments directly instead of bothering you with minor comments. There doesn't seem to be any performance degradation, so we can leave it on by default. |
|
Closing this PR as it is superseded by #308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements basic
enclosing_rangesfor JS/TS.The following are implemented:
To facilitate snapshot handling, I rebased the current snapshot formatter on the one used for Python. These two should be put in common at a later stage.
The implementation itself is very straightforward, and I believe can easily be extended to support other features.
Related to #278
Test plan
Added the following snapshots, with their input and output. The output was visually confirmed.
enclosing-rangesnapshot to test JS support,enclosing-range-tssnapshot to test TS support