Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Import defradb/errors for Join #3343

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

ChrisBQu
Copy link
Collaborator

Relevant issue(s)

Resolves #3334

Description

In many locations in the code base, we were importing the "errors" package in order to utilize the Join function. However, we now have this functionality as part of our own errors package. So throughout the codebase import statements, "errors" has been changed to "github.com/sourcenetwork/defradb/errors"

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Specify the platform(s) on which this was tested:

  • Windows

@ChrisBQu ChrisBQu added the area/errors Related to the internal management or design of our error handling system label Dec 23, 2024
@ChrisBQu ChrisBQu added this to the DefraDB v0.16 milestone Dec 23, 2024
@ChrisBQu ChrisBQu self-assigned this Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (65fa135) to head (45941ad).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3343      +/-   ##
===========================================
+ Coverage    78.10%   78.13%   +0.02%     
===========================================
  Files          388      388              
  Lines        35398    35398              
===========================================
+ Hits         27647    27655       +8     
+ Misses        6119     6110       -9     
- Partials      1632     1633       +1     
Flag Coverage Δ
all-tests 78.13% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/definitions.go 75.63% <ø> (ø)
client/document.go 64.08% <ø> (ø)
datastore/prefix_query.go 83.78% <ø> (ø)
http/client_collection.go 45.45% <ø> (ø)
internal/db/description/collection.go 54.21% <ø> (ø)
internal/db/fetcher/indexer_iterators.go 74.95% <ø> (ø)
internal/db/fetcher/multi.go 74.14% <ø> (ø)
internal/db/view.go 64.42% <ø> (ø)
internal/request/graphql/schema/manager.go 88.46% <ø> (ø)
node/node.go 57.36% <ø> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65fa135...45941ad. Read the comment docs.

@ChrisBQu ChrisBQu changed the title chore: Import defradb/errors instead of standard library package chore: Import defradb/errors for Join() Dec 23, 2024
@ChrisBQu ChrisBQu changed the title chore: Import defradb/errors for Join() chore: Import defradb/errors for Join Dec 23, 2024
@ChrisBQu ChrisBQu marked this pull request as ready for review December 23, 2024 20:32
@ChrisBQu ChrisBQu requested a review from a team December 23, 2024 20:32
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning this up.

@ChrisBQu ChrisBQu merged commit 84b0660 into sourcenetwork:develop Jan 1, 2025
41 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/errors Related to the internal management or design of our error handling system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to defradb/errors.Join from stdlib/errors.Join
2 participants