Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve sourmash tax metagenome lingroup output #3361

Open
bluegenes opened this issue Oct 24, 2024 · 0 comments
Open

improve sourmash tax metagenome lingroup output #3361

bluegenes opened this issue Oct 24, 2024 · 0 comments
Labels
5.0 issues to address for a 5.0 release

Comments

@bluegenes
Copy link
Contributor

#3311 changes the behavior of csv_summary when a lingroup file is provided, limiting summarized reporting to just the named lingroups. While the output is very similar to the lingroup output we already have, the most important difference is that the sample name is included in the output, meaning that we get intelligible results when running tax metagenome on more than one sample.

Prior tax metagenome behavior was to always generate a lingroup output file when a lingroups file is provided. In #3311, we disable that for multiple queries, since the results wouldn't make sense. We do not replace it with another default, but instead add a recommendation to the help + doc.

In the next major version (5.0), we could consider changing the default lingroup output to csv_summary, since it's actually useful for multiple files. Or, we could modify the lingroup output itself to include query information.

@bluegenes bluegenes added the 5.0 issues to address for a 5.0 release label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 issues to address for a 5.0 release
Projects
None yet
Development

No branches or pull requests

1 participant