Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated sourmash core code more broadly #196

Closed
bluegenes opened this issue Jan 24, 2024 · 0 comments · Fixed by #197
Closed

use updated sourmash core code more broadly #196

bluegenes opened this issue Jan 24, 2024 · 0 comments · Fixed by #197

Comments

@bluegenes
Copy link
Contributor

#134 makes necessary changes to allow us to use the new 0.12.0+ rust sourmash core.

With the new core, we can:

  • Improve zip loading more broadly
    • Use core Collection and Manifest code --> standardize/improve zip and sigpath loading
  • Standardize / improve selection
    • Use Collection::Select/Manifest::Select for subsetting when loading from zip
    • use Signature::Select to do selection and downsampling of single sigs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant