MRG: Use updated core GatherResult to enable full results
#205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluegenes
changed the base branch from
upd-smash-core
to
use-core-more-broadly
bluegenes
force-pushed
the
use-upd-gatheresult
branch
from
889a034 to
6e94b73
Compare
|
sourmash core v0.13.0 is out - https://crates.io/crates/sourmash |
bluegenes
changed the title
GatherResult to enable full resultsGatherResult to enable full results
|
@ctb ready for review |
ctb
approved these changes
Feb 26, 2024
|
Nice work! I enabled auto-merge, FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new rust calculations to produce a full gather_csv from rocksdb
fastmultigatherRequires new sourmash core release that includes: